Swap to using a specific implementation of CompareConverter

CommunityToolkit / Maui

The .NET MAUI Community Toolkit is a community-created library that contains .NET MAUI Extensions, Advanced UI/UX Controls, and Behaviors to help make your life as a .NET MAUI developer easier

https://learn.microsoft.com/dotnet/communitytoolkit/maui

MIT License

2.28k stars 403 forks source link

Swap to using a specific implementation of CompareConverter #2346

Open bijington opened 1 week ago

bijington commented 1 week ago

Description of Change

Linked Issues

Workaround for https://github.com/dotnet/maui/issues/25871

PR Checklist
[ ] Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
[ ] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR
[ ] Changes adhere to coding standard
[ ] Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

bijington commented 1 week ago

We also consider marking CompareConverter [Obsolete] or abstract or even delete it entirely. This is not to be confused with CompareConverter<TValue, TReturn>

brminnick commented 1 week ago

Awesome work Shaun! Let's wait a bit to hear from the MAUI team on the root cause. Mat biggest concern is that the underlying bug will break existing users of CompareConverter too.

If they can quickly push a hotfix, we'll wait for the next MAUI update.

If it'll be a few weeks before a fix, or they determine that the bug is isolated to our sample app, we can merge this work-around and note the required workaround in our Release Notes.

CommunityToolkit / Maui

Swap to using a specific implementation of CompareConverter #2346

Description of Change

Linked Issues

PR Checklist

Additional information