search

CommunityToolkit / Microsoft.Toolkit.Win32

ARCHIVE - This repository contained XAML Islands wrapper controls and tooling for XAML Islands with WinUI 2, see readme for more info about XAML Islands with WinUI 3 and the WindowsAppSDK.
https://aka.ms/windowsappsdk
Other
383 stars 89 forks source link

[PR] The proj files have been updated to enable SourceLink #277

Closed JTOne123 closed 4 years ago

JTOne123 commented 4 years ago

CSProj files have been updated to enable SourceLink in your nuget

[This pull request was created with an automated workflow]

I noticed that your repository and Nuget package are important for our .NET community, but you still haven't enabled SourceLink.

We have to take 2 steps: 1) Please approve this pull request and make .NET a better place for .NET developers and their debugging. 2) Then just upload the .snupkg file to https://www.nuget.org/ (now you can find the snupkg file along with the .nuget file)

You can find more information about SourceLine at the following links
https://github.com/dotnet/sourcelink https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx

If you are interesting about this automated workflow and how it works
https://github.com/JTOne123/GitHubMassUpdater

If you notice any flaws, please comment and I will try to make fixes manually

ghost commented 4 years ago

Thanks JTOne123 for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

michael-hawker commented 4 years ago

Thanks @JTOne123 we should be updating this in our root props file here: https://github.com/windows-toolkit/Microsoft.Toolkit.Win32/blob/master/Directory.Build.props#L111

We had done similar work here: https://github.com/windows-toolkit/WindowsCommunityToolkit/pull/3301/files#diff-4b2f402501d23abbede6eac0f47783e4R54 but I guess we forgot to do it here too.

FYI @azchohfi