CommunityToolkit / Microsoft.Toolkit.Win32

ARCHIVE - This repository contained XAML Islands wrapper controls and tooling for XAML Islands with WinUI 2, see readme for more info about XAML Islands with WinUI 3 and the WindowsAppSDK.
https://aka.ms/windowsappsdk
Other
383 stars 89 forks source link

Added symbols to XamlApplication package. #293

Open azchohfi opened 3 years ago

azchohfi commented 3 years ago

Fixes #292

PR Type

What kind of change does this PR introduce?

What is the current behavior?

No symbols at all for the Microsoft.Toolkit.Win32.UI.XamlApplication package.

What is the new behavior?

Stripped and added symbols for the Microsoft.Toolkit.Win32.UI.XamlApplication package.

PR Checklist

Please check if your PR fulfills the following requirements:

ghost commented 3 years ago

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

ocalvo commented 3 years ago

Can you make sure that the Xaml Islands repo still builds and that MSIX can still be compiled and run after this change?

michael-hawker commented 3 years ago

@azchohfi is there anything left before we merge this?

azchohfi commented 3 years ago

Do not merge! This was not working.