search

CommunityToolkit / Microsoft.Toolkit.Win32

ARCHIVE - This repository contained XAML Islands wrapper controls and tooling for XAML Islands with WinUI 2, see readme for more info about XAML Islands with WinUI 3 and the WindowsAppSDK.
https://aka.ms/windowsappsdk
Other
384 stars 89 forks source link

[Question] Why break after `Application` type found? #347

Open MartinZikmund opened 2 years ago

MartinZikmund commented 2 years ago

While browsing the code we noticed that in MetadataProviderDiscovery the enumeration is stopped when a type derived from Application is found. Is this intentional? This seems that a mere change in type name could result in different output of the DiscoverMetadataProviders method - e.g. if the type deriving from application will be called ZApplication it will probably show up last in the list of types, so all IXamlMetadataProvider types will be returned, but if we rename it to AAplication it will now be discovered early and will be the only thing returned, potentially.

ghost commented 2 years ago

Hello MartinZikmund, thank you for your interest in Win32!

I have automatically added a "needs triage" label to help get things started. Our team will look into the question and answer ASAP. Other community members may also answer the question and provide feedback 🙌

michael-hawker commented 2 years ago

FYI @marb2000 @ocalvo