search

CommunityToolkit / Tooling-Windows-Submodule

Community Toolkit infrastructure for use as a submodule 'tooling' directory in other repositories.
Other
32 stars 10 forks source link

Update to Microsoft.WindowsAppSDK 1.6, enable AoT. #205

Open Arlodotexe opened 3 months ago

Arlodotexe commented 3 months ago

Tracking issue for updating toolkit tooling to WindowsAppSDK 1.6 and enabling AoT support.

Preview1:

Preview2:

Stable:

CsWinRTAotWarningLevel 2:

General Gallery / Component issues:

michael-hawker commented 2 months ago

Thanks @Arlodotexe, I've unblocked you on the Preview2 PRs. As discussed, we'll just snap those in as a check-point and then update to the stable 1.6 bits.

michael-hawker commented 2 months ago

Got a report from building with 1.6-stable against our latest 1.6-preview2 bits with this error:

1>C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\amd64\Microsoft.Common.CurrentVersion.targets(5321,5): error MSB3030: Could not copy the file "C:\Users....nuget\packages\communitytoolkit.winui.animations\8.2.240909-build.1181\lib\net8.0-windows10.0.22621\CommunityToolkit.WinUI.Animations\runtimes\win-x64\native\WebView2Loader.dll" because it was not found.

looks like a path problem:

Wrong C:\Users....nuget\packages\communitytoolkit.winui.animations\8.2.240909-build.1181\lib\net8.0-windows10.0.22621\CommunityToolkit.WinUI.Animations\runtimes\win-x64\native\

Correct C:\Users....nuget\packages\communitytoolkit.winui.animations\8.2.240909-build.1181\lib\net8.0-windows10.0.22621.0\CommunityToolkit.WinUI.Animations\runtimes\win-x64\native Note the missing .0 in the TFM part of the path, should be net8.0-windows10.0.22621.0 but was net8.0-windows10.0.22621.

Talking with @Arlodotexe it sounds similar (though different) to the issue Morten had reported in Labs here: https://github.com/CommunityToolkit/Labs-Windows/pull/569

Though with all the WebView changes between preview1 and stable, we may just want to have them reproduce once we have a 1.6 build to try.

michael-hawker commented 2 months ago

Screenshot of nuget package: image

the issue is on the packaged from ctk which has 2 folders for the .net8-windowsSdk version same for other .net versions the only diff is that 1 has the bits for CTK and the other has the WebView2 dll

michael-hawker commented 2 months ago

They tried the 1.6 bits from the latest PR, same issue, if they merge the folders and move the bits in the wrong place to the right place, it works.

BlameTwo commented 2 days ago

May I ask how the progress is now?