CommunityToolkit / Windows

Collection of controls for WinUI 2, WinUI 3, and Uno Platform developers. Simplifies and demonstrates common developer tasks building experiences for Windows with .NET.
https://aka.ms/windowstoolkitdocs
Other
591 stars 74 forks source link

Toolkit Settings Expander Fails Axe Scan #240

Open karkarl opened 1 year ago

karkarl commented 1 year ago

Describe the bug

SettingsExpander is used in WinUI3 Gallery, and the element does not pass the accessibility insights scan.

I believe the fix is from Toolkit side to bind appropriate AutomationProperties.Name to its elements.

image

Steps to reproduce

- Install WinUI 3 Gallery from Store
- Navigate to Design Guidance -> Icons
- Run Accessibility Insights for Windows Scan on the page
- Observe failed checks

Expected behavior

Axe tests should be passing.

Screenshots

No response

Code Platform

Windows Build Number

Other Windows Build number

No response

App minimum and target SDK version

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, but only if others can assist.

michael-hawker commented 1 year ago

@karkarl was talking to @niels9001, by default the automation name is set based on the Header which looks like you don't have here. For now, you should be able to set yourself on the control?