CommunityToolkit / Windows

Collection of controls for WinUI 2, WinUI 3, and Uno Platform developers. Simplifies and demonstrates common developer tasks building experiences for Windows with .NET.
https://aka.ms/windowstoolkitdocs
Other
603 stars 76 forks source link

Reintroduce XAML Island Helpers #338

Open myth384 opened 9 months ago

myth384 commented 9 months ago

Describe the bug

Like was written on the 8.0 release notes, Windows App SDK 1.4 indeed introduced XAML Island support, but only by adding DesktopWindowXamlSource. The Hosting API of WinUI 3 looks comparable to UWP. There are no convenience wrappers available around this class, like the WindowsXamlHost control from Microsoft.Toolkit.Win32. The absence of such control makes XAML Islands impractical for migrating WPF/WinForms apps to WinUI 3. Therefore I want to suggest to reconsider implementing WindowsXamlHost.

Steps to reproduce

Not applicable.

Expected behavior

Not applicable.

Screenshots

No response

Code Platform

Windows Build Number

Other Windows Build number

No response

App minimum and target SDK version

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

michael-hawker commented 9 months ago

@myth384 originally these wrappers shipped in the Toolkit as WinUI didn't exist as a library yet originally.

If there aren't sufficient helpers with what's shipped in the WindowsAppSDK/WinUI, then we should file an issue there for them to ship alongside the APIs that support these scenarios vs. living in the Toolkit.

Would you mind refiling this on the WinUI repo? I can't transfer this here.

Feel free to call out this and other related issues/discussions on this topic: