CommunityToolkit / Windows

Collection of controls for WinUI 2, WinUI 3, and Uno Platform developers. Simplifies and demonstrates common developer tasks building experiences for Windows with .NET.
https://aka.ms/windowstoolkitdocs
Other
550 stars 71 forks source link

Port Shadows #5

Open niels9001 opened 1 year ago

niels9001 commented 1 year ago
### Base Porting Checklist
- [x] Update namespace (to `CommunityToolkit.WinUI.Shadows`)
- [x] Merge differences from UWP main to WinAppSDK
- [ ] Import original doc or setup new doc. Needs a refresh/update, and probably split
- [ ] Samples. Only setup StringFormatConverter test case, need others
- [ ] All brought over tests pass for UWP/WinAppSDK
- [ ] Add more tests for other converters not covered? (or at least well-used ones)
- [ ] Support for WASM via Uno Platform
## Notable Changes
- [ ] DropShadowPanel is deprecated - but a lot of (1P) apps use it. Any actions needed to make migration easier? Do we still port it?
## Future Improvements
michael-hawker commented 1 year ago

@niels9001 maybe we should take a quick look at where they're still using it and see if we can ascertain why that is and how we can help migrate them.

michael-hawker commented 1 year ago

These are technically extensions, so for now bringing them over with #6