CommunityToolkit / Windows

Collection of controls for WinUI 2, WinUI 3, and Uno Platform developers. Simplifies and demonstrates common developer tasks building experiences for Windows with .NET.
https://aka.ms/windowstoolkitdocs
Other
550 stars 71 forks source link

TextBoxExtensions sample in gallery crashes under Windows App SDK #510

Open Arlodotexe opened 1 month ago

Arlodotexe commented 1 month ago

Describe the bug

Under the latest main commit, opening the TextBoxExtensions sample will cause the gallery app to crash. image

   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|38_0(Int32 hr)
   at ABI.Windows.UI.Input.IRadialControllerStaticsMethods.CreateForCurrentView(IObjectReference _obj)
   at Windows.UI.Input.RadialController.CreateForCurrentView()
   at CommunityToolkit.WinUI.TextBoxExtensions.OnSurfaceDialOptionsPropertyChanged(DependencyObject d, DependencyPropertyChangedEventArgs e) in /_/components/Extensions/src/Text/TextBoxExtensions.SurfaceDial.cs:line 138
   at ABI.Microsoft.UI.Xaml.PropertyChangedCallback.Do_Abi_Invoke(IntPtr thisPtr, IntPtr d, IntPtr e)

This behavior is not present when running the gallery under UWP.

Steps to reproduce

1. Clone the repo
2. Generate the gallery solution, include the Extensions component and the wasdk multitarget/head.
3. Build and deploy the wasdk gallery 
4. Navigate to the TextBoxExtensions sample page and observe crash.

Expected behavior

No crash

Screenshots

No response

Code Platform

Windows Build Number

Other Windows Build number

No response

App minimum and target SDK version

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

Arlodotexe commented 1 week ago

This error will throw even after disabling AoT, suggesting it might be a regression that happened between Microsoft.WindowsAppSdk 1.5 and 1.6.