[Sample App] Commands for Sample Pages should have more options for manipulation

CommunityToolkit / WindowsCommunityToolkit

The Windows Community Toolkit is a collection of helpers, extensions, and custom controls. It simplifies and demonstrates common developer tasks building .NET apps with UWP and the Windows App SDK / WinUI 3 for Windows 10 and Windows 11. The toolkit is part of the .NET Foundation.

Other

5.89k stars 1.38k forks source link

I'm submitting a...

Sample app request

Should be related to general improvements #1438 and originally needed by PR #1896.

Current behavior

A sample page can only add new commands for the sample at the commandbar, but outside of the user clicking to invoke them has no way to interact with the button. This makes it hard to enable/disable buttons, hide/show buttons, or have toggle buttons.

Expected behavior

We should extend the SampleCommand and RegisterNewCommand paradigms to allow for:

[ ] Returning the SampleCommand on RegisterNewCommand
[ ] Shell CommandBar listens to updates to properties for Label and new Parameter, IsVisible, and IsEnabled properties on the SampleCommand
[ ] P2: Provide the option when registering to set the button type to a 'togglable' one.

CommunityToolkit / WindowsCommunityToolkit