CommunityToolkit / WindowsCommunityToolkit

The Windows Community Toolkit is a collection of helpers, extensions, and custom controls. It simplifies and demonstrates common developer tasks building .NET apps with UWP and the Windows App SDK / WinUI 3 for Windows 10 and Windows 11. The toolkit is part of the .NET Foundation.
https://docs.microsoft.com/windows/communitytoolkit/
Other
5.9k stars 1.37k forks source link

Latest version of Microsoft.Toolkit.Uwp.UI.Controls is causing errors while running VSTS build test #2452

Closed gaojunxuan closed 6 years ago

gaojunxuan commented 6 years ago

I'm submitting a...

Bug report (I searched for similar issues and did not find one)

Current behavior

The latest version of Microsoft.Toolkit.Uwp.UI.Controls package are causing error while running VSTS Build Test. I'm using Visual Studio App Center to run build tests on my UWP app while the build test kept failing after updating the Microsoft.Toolkit.Uwp.UI.Controls package from 2.1.1 to the latest version. I contacted the App Center support team and they told me to rollback the package, which solved my problem temporarily.

The reason causing this problems seems to be ColorCode, which is now one of the dependencies of the latest version of Microsoft.Toolkit.Uwp.UI.Controls. This dependency is a .NET Standard library and it is generating portable PDBs which will cause an error while running the "publishing symbols" step of VSTS build test.

I also found some similar issues on StackOverflow and GitHub.

https://stackoverflow.com/questions/52031702/errors-creating-app-package-uwp-appx-fatal-error-cmf1106-failed-to-open-in

https://github.com/dotnet/sdk/issues/955

Expected behavior

Minimal reproduction of the problem with instructions

  1. Create a blank UWP project
  2. Install the latest version of Microsoft.Toolkit.Uwp.UI.Controls form Nuget
  3. Run a build test on VSTS or Visual Studio App Center

Environment

Nuget Package(s): Microsoft.Toolkit.Uwp.UI.Controls

Package Version(s): 4.0.0

Windows 10 Build Number:
- [ ] Creators Update (15063)
- [ ] Fall Creators Update (16299)
- [x] April 2018 Update (17134)
- [ ] Insider Build (build number: )

App min and target version:
- [x] Creators Update (15063)
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] Insider Build (xxxxx)

Device form factor:
- [x] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [x] 2017 (version: )
- [ ] 2017 Preview (version: )
kbrons commented 6 years ago

Seems to be more of a ColorCode or .NET Standard issue than the toolkit's. You should continue reporting to the .NET Standard issue or, if there's a fix that could be done from ColorCode's side, you can create an issue in this repository.

@WilliamABradley you might want to take a look at this.

WilliamABradley commented 6 years ago

@gaojunxuan @kbrons I will update ColorCode to use Full PDB Output and create a PR to the Toolkit to fix this.

Release Mode should still work.

nmetulev commented 6 years ago

@WilliamABradley, has this been completed? If not, could you create an issue for tracking?

nmetulev commented 6 years ago

ping @WilliamABradley

WilliamABradley commented 6 years ago

@nmetulev I should be able to work on this tonight.

nmetulev commented 6 years ago

PR merged.