CommunityToolkit / WindowsCommunityToolkit

The Windows Community Toolkit is a collection of helpers, extensions, and custom controls. It simplifies and demonstrates common developer tasks building .NET apps with UWP and the Windows App SDK / WinUI 3 for Windows 10 and Windows 11. The toolkit is part of the .NET Foundation.
https://docs.microsoft.com/windows/communitytoolkit/
Other
5.88k stars 1.38k forks source link

[Feature] Smoke Test Pipeline Should Report Metrics on Application Sizes #3600

Closed michael-hawker closed 3 years ago

michael-hawker commented 3 years ago

Describe the problem this feature would solve

Besides just checking the final output of the NuGet package, one reason for the Smoke Tests are to help us understand the impact the toolkit packages have on the final size of an application.

While the Smoke Tests currently run in the CI and generate these independent apps. The size isn't currently reported back in a nicely consumable way either at the end of that job or with some sort of bot back to the issue itself.

Describe the solution

MVP: When smoke test is completed, it lists a table at the end of each package and the resulting app size to the console. This way we can scroll to the end of the job and get that data when needed.

Nice to haves:

Additional context & Screenshots

Somewhat related to #3560 as well. And to address being able to check and help with #3145 more explicitly.

michael-hawker commented 3 years ago

Alright so the SmokeTests drop to SmokeTests\AppPackages and the final msixupload packages have a good breakdown of all the dependent dlls.

Each msixupload package has an inner msixbundle package and then an inner msix package, if we unzip all 3 of these, we can get a flat list of all the dlls required for the app. (Seems like there's a lot from the system, so need to check the new baseline version.) Then we can investigate what the extra dependencies are for each package besides the baseline and spit that out.

michael-hawker commented 3 years ago

I think the strategy here I'm going to follow is to index all the files/sizes in the UWP Baseline project. Then for each other project, find the outliers to that list and report what those are and their sizes above the baseline.

This should give us not only the overall footprint each package adds to the toolkit, but it should also help us understand other dependencies each of those packages bring and how they contribute to that total.

I'll then try and output that to the console. Luckily this is something I can easily test locally. I'm going to make it a separate PowerShell script in the SmokeTests project, and then we can just call it from the DevOps YAML file after the Smoke Tests run.

@azchohfi do you know if there's a known location where we can store a file/metadata associated the last main build in DevOps or would we have to check it in somewhere to some repo? Curious if in the future we could have the script fetch that from somewhere and compare against it to know how things are changing for a given PR?

azchohfi commented 3 years ago

Not sure what the best way to do this would be. We could upload an xml or json file with these results somewhere and use that, but I don't know if we could just use the same repo for that. Not sure if we could use the ADO artifacts for that either, since there is a retention policy for builds. Maybe a release pipeline could push this to an Azure storage, and then the PRs pipelines could compare it with a known URL. I'm not sure if there is a more standard way of doing this. Lets brainstorm.

michael-hawker commented 3 years ago

@azchohfi Hmm, was just messing with the DownloadPipelineArtifact wondering if we published it as an Artifact if we could use the specific flag to somehow grab the latest pipeline artifact from the main branch? Not sure if we can get that specific with the project guid? runVersion latestFromBranch maybe? 🤔 That looks promising. I can try it out later once I get the base script running.

Ref: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/utility/download-pipeline-artifact?view=azure-devops

azchohfi commented 3 years ago

Not sure, but it seems like it might work.

michael-hawker commented 3 years ago

Looking good so far:

image

Need to test in the CI. Some dependencies I didn't quite realize were so big and rooted lower in the Toolkit like System.Text.Json is large and everywhere and it pulls in another one. Also have no idea what's pulling in the Microsoft.Bcl.AsyncInterfaces dependency...?

michael-hawker commented 3 years ago

Right now it just outputs to the host, need to add more to actually spit out a file that we could compare against.

When we do that, we can also output this cleaner as a table and have an extra column for the comparison.

And we could colorize it fancier too! https://stackoverflow.com/a/49038815/8798708