search

CommunityToolkit / WindowsCommunityToolkit

The Windows Community Toolkit is a collection of helpers, extensions, and custom controls. It simplifies and demonstrates common developer tasks building .NET apps with UWP and the Windows App SDK / WinUI 3 for Windows 10 and Windows 11. The toolkit is part of the .NET Foundation.
https://docs.microsoft.com/windows/communitytoolkit/
Other
5.82k stars 1.37k forks source link

[IncrementalLoadingCollection] Should reset HasMoreItems to True if data is not null #3954

Open HppZ opened 3 years ago

HppZ commented 3 years ago

image

if LoadDataAsync failed due to a http request or something else, HasMoreItems is set to false, and I will show a Button for user to retry and call LoadMoreItemsAsync, if retry succeed, HasMoreItems is still false, when user scroll to bottom of ListView, LoadMoreItemsAsync will not be called automatically.

ghost commented 3 years ago

Hello HppZ, thank you for your interest in Windows Community Toolkit!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible.. Other community members may also answer the question and provide feedback 🙌

Kyaa-dost commented 3 years ago

@HppZ Opening this up for discussion if any community member wants to provide insight on this matter.

HppZ commented 3 years ago

discussion url?

Kyaa-dost commented 3 years ago

discussion url?

@HppZ we have recently started the Discussion channel where the community can also participate and answer the questions but since this issue was posted here, therefore, I have applied the discussion label which will also facilitate the conversation.

Kyaa-dost commented 3 years ago

@azchohfi any insight here?

Kyaa-dost commented 3 years ago

@HppZ based on the conversation from #3852 are you going to working on this one and create a separate PR or was this already fixed in that PR? Just looking for more clarity here.