search

CommunityToolkit / WindowsCommunityToolkit

The Windows Community Toolkit is a collection of helpers, extensions, and custom controls. It simplifies and demonstrates common developer tasks building .NET apps with UWP and the Windows App SDK / WinUI 3 for Windows 10 and Windows 11. The toolkit is part of the .NET Foundation.
https://docs.microsoft.com/windows/communitytoolkit/
Other
5.88k stars 1.38k forks source link

ListDetailsView: Back/Forward nav buttons are non-operational #4133

Open XAML-Knight opened 3 years ago

XAML-Knight commented 3 years ago

Describe the bug

When interacting with the ListDetailsView in the Sample App, clicking either the Back or Forward buttons (near bottom of list view on left-hand side) does not perform as expected.

Steps to Reproduce

No, but the Sample App's ListDetailsView page just happens to be blank.

Steps to reproduce the behavior:

  1. Given the following environment (Sample App from main)
  2. Go to ListDetailsView
  3. Click on either the back or forward button (in the list view, on the left-hand side)

Expected behavior

The selected item in the list view (on left-hand side) will change depending on which direction (back, forwards) was initiated by the user

Screenshots

image

Environment

Debug, x64

Device form factor:

Visual Studio

ghost commented 3 years ago

Hello XAML-Knight, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

michael-hawker commented 3 years ago

Thanks @XAML-Knight. These are part of the sample itself, eh? Are they hooked up and not doing anything, or do they just provide no function?

XAML-Knight commented 3 years ago

The ListDetailsView control, itself, serves up an empty CommandBar as a dependency property, and it stays empty, until the Sample page comes along and places two buttons (Back, Forward) in it, with no events/commands wired up.

michael-hawker commented 3 years ago

Yeah, think these were just for design aesthetic vs. meaning to be functional.

We should probably have a comment in the XAML to point out they are placeholders.

We could theoretically create new behaviors for a ListViewBase to move the selected item next or previous and wire those up in the sample via XAML. Not sure how useful those would be, probably a separate issue for us to track and get some community feedback on.