CommunityToolkit / WindowsCommunityToolkit

The Windows Community Toolkit is a collection of helpers, extensions, and custom controls. It simplifies and demonstrates common developer tasks building .NET apps with UWP and the Windows App SDK / WinUI 3 for Windows 10 and Windows 11. The toolkit is part of the .NET Foundation.
https://docs.microsoft.com/windows/communitytoolkit/
Other
5.86k stars 1.37k forks source link

Microsoft.Toolkit.Uwp.UI.Controls.DataGrid RowHeight below 32px #4828

Open sdanev opened 1 year ago

sdanev commented 1 year ago

Describe the bug

DataGrid RowHeight cannot be set below 32px.

The Default DataGridCell Style has setter MinHeight=32.

Regression

No response

Reproducible in sample app?

Steps to reproduce

DataGrid.RowHeight = 20;

Expected behavior

Row Height to be set to 20px

Screenshots

No response

Windows Build Number

Other Windows Build number

No response

App minimum and target SDK version

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Nuget packages

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

ghost commented 1 year ago

Hello sdanev, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

michael-hawker commented 1 year ago

@sdanev should probably be better exposed with a resource value, but you can copy the style to define your own and change this behavior currently.

ekdahl commented 1 year ago

A preferred solution would be configurable padding instead so the row heights can still be different depending on row contents, like multiple lines (and of course allowing lower minimum height than 32).