search

CommunityToolkit / WindowsCommunityToolkit

The Windows Community Toolkit is a collection of helpers, extensions, and custom controls. It simplifies and demonstrates common developer tasks building .NET apps with UWP and the Windows App SDK / WinUI 3 for Windows 10 and Windows 11. The toolkit is part of the .NET Foundation.
https://docs.microsoft.com/windows/communitytoolkit/
Other
5.88k stars 1.37k forks source link

Update DataGrid Style #4900

Open BenjaminTGa opened 1 year ago

BenjaminTGa commented 1 year ago

Describe the problem

I have discovered that the DataGrid component follows WinUI 3 (or Windows 11) styling. It doesn't look great, and really clashes with the look of my WinUI 3 app. Given that this is only grid component that can be used for WinUI 3 apps, I feel it's important to make it match the aesthetics of WinUI 3.

Describe the solution

I think that a new version of the DataGrid could be made, maybe called WinUI3DataGrid, or Win11DataGrid, or that the original DataGrid component could be renamed LegacyDataGrid and the new one called DataGrid.

Alternatives

No response

Additional info

No response

Help us help you

Yes, but only if others can assist.

I'm not great with WinUI 3, but I can to really basic stuff. So I guess I should say: Yes, but only if others can assist and it's really easy.

ghost commented 1 year ago

Hello, 'BenjaminTGa! Thanks for submitting a new feature request. I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future!

michael-hawker commented 1 year ago

@BenjaminTGa see the work we're doing in https://github.com/CommunityToolkit/Labs-Windows/discussions/415

I also think you mean Windows 10 style? In either case, we wouldn't create a new control, but just update the existing style or create an alternate.

Though, we don't have plans in the near future to work on this component. It won't be part of our initial migration to the new repository at https://github.com/CommunityToolkit/Windows

michael-hawker commented 1 year ago

@niels9001 I think you did some poking here for TemplateStudio, should we dump that style in a gist for now?

BenjaminTGa commented 1 year ago

@BenjaminTGa see the work we're doing in CommunityToolkit/Labs-Windows#415

I also think you mean Windows 10 style? In either case, we wouldn't create a new control, but just update the existing style or create an alternate.

Though, we don't have plans in the near future to work on this component. It won't be part of our initial migration to the new repository at https://github.com/CommunityToolkit/Windows

Yes, I do mean the Windows 10 style. Most of the Windows Community Toolkit widgets follow that look, but, as I said before, it's the only grid component WinUI 3 has so it's important for it to follow WinUI 3 styling.

BenjaminTGa commented 1 year ago

Looks good for the link you provided (Labs Windows). Just wondering how ready it is to be released.