SelectedItem not maintained in ComboBox when property was bound using CommunityToolkit.WinUI.FrameworkElementExtensions

ChidanandMurugaiah commented 1 month ago

Describe the bug

We are using the FrameworkElementExtension.Ancestor for the ComboBox.ItemsSource binding. When we unload the ComboBox, the binding remains active, causing the SelectionChanged event to trigger after the Unloaded event. As a result, the SelectedItem is not maintained in our application. This issue specifically occurs when using the FrameworkElementExtension from the CommunityToolKit.WinUI.Extensions package.

Sample - ComboBox_BindingIssue.zip

Unnecessary calls for SelectionChanged event after Unloaded event triggers - UnnecessaryCallForSelectionChanged.zip

Regression

No response

Reproducible in sample app?

[X] This bug can be reproduced in the sample app.

Steps to reproduce

Replication Procedure

1.Run the sample
2.Click the drop down of the FrameworkElementExtension Binding combo box.
3.Select Personnel.
4.Click Reset Control button.

Expected behavior

Expected behavior - TextBox Text needs to be remains the same. Observed behavior - TextBox Text changes to null.

Screenshots

https://github.com/CommunityToolkit/WindowsCommunityToolkit/assets/124787498/31d24d2f-c438-4715-bac2-db71d9b2697b

Windows Build Number

[ ] Windows 10 1809 (Build 17763)
[ ] Windows 10 1903 (Build 18362)
[ ] Windows 10 1909 (Build 18363)
[ ] Windows 10 2004 (Build 19041)
[ ] Windows 10 20H2 (Build 19042)
[ ] Windows 10 21H1 (Build 19043)
[X] Windows 11 21H2 (Build 22000)
[ ] Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

[ ] Windows 10, version 1809 (Build 17763)
[ ] Windows 10, version 1903 (Build 18362)
[ ] Windows 10, version 1909 (Build 18363)
[X] Windows 10, version 2004 (Build 19041)
[ ] Other (specify)

Other SDK version

No response

Visual Studio Version

2022

Visual Studio Build Number

17.10.1

Device form factor

Desktop

Nuget packages

CommunityToolKit.WinUI.Extensions - version - 8.0.240109 CommunityToolKit.Mvvm - version - 8.2.2 Microsoft.Windows.SDK.BuildTools - version - 10.0.22621.765 MicrosoftWindowsSDKApp - version - 1.5.240607001

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

ChidanandMurugaiah commented 1 month ago

Are there any updates regarding this issue? We created this issue last week but still we didn't get any updates from your side.

weiyoucheng commented 1 month ago

I look forward to fixing this bug as soon as possible

CommunityToolkit / WindowsCommunityToolkit