michael-hawker
commented
2 years ago Looks like it was introduced here as part of the transfer from the WCT:
I just noticed this migrating the WinUI branch of the Toolkit on top of the 8.0.0 .NCT release...
Describe the bug
Not sure how this was missed, but the ISettingsStorageHelper has a different namespace than all the other helpers here:
https://github.com/CommunityToolkit/dotnet/blob/9d1a525d04299e5421cb3e5917825fee2bc11a18/CommunityToolkit.Common/Helpers/ObjectStorage/ISettingsStorageHelper.cs#L5
All the other helpers are
CommunityToolkit.Common.Helpers...https://github.com/CommunityToolkit/dotnet/blob/9d1a525d04299e5421cb3e5917825fee2bc11a18/CommunityToolkit.Common/Helpers/ObjectStorage/IFileStorageHelper.cs#L8
Similarly the extension helper to it has a
.Extensions:https://github.com/CommunityToolkit/dotnet/blob/9d1a525d04299e5421cb3e5917825fee2bc11a18/CommunityToolkit.Common/Extensions/ISettingsStorageHelperExtensions.cs#L8
Where the other extensions do not and are just part of
CT.Common.Regression
No response
Steps to reproduce
Expected behavior
Consistency in Namespace
Screenshots
No response
IDE and version
VS 2022
IDE version
No response
Nuget packages
Nuget package version(s)
8.0.0
Additional context
Not sure if there's other places to audit?
Help us help you
Yes, but only if others can assist