Wrong test assertion in Test_Span2D{T} - Githubissues

CommunityToolkit / dotnet

.NET Community Toolkit is a collection of helpers and APIs that work for all .NET developers and are agnostic of any specific UI platform. The toolkit is maintained and published by Microsoft, and part of the .NET Foundation.

https://docs.microsoft.com/dotnet/communitytoolkit/?WT.mc_id=dotnet-0000-bramin

Other

2.99k stars 294 forks source link

Wrong test assertion in Test_Span2D{T} #648

Open GabrieleMessina opened 1 year ago

GabrieleMessina commented 1 year ago

Describe the bug

In this test we check that array is equals to itself but probably it should be compared with span2d or with a constant expected value.

https://github.com/CommunityToolkit/dotnet/blob/b8df95a9f3531524209b4bf483f684a1c52e30a9/tests/CommunityToolkit.HighPerformance.UnitTests/Memory/Test_Span2D%7BT%7D.cs#L296-L316

Regression

No response

Steps to reproduce

1. Open the code :)

Expected behavior

the array should be compared with the span2d variable or with a constant expected value.

Screenshots

No response

IDE and version

VS 2022

IDE version

No response

Nuget packages

[ ] CommunityToolkit.Common
[ ] CommunityToolkit.Diagnostics
[ ] CommunityToolkit.HighPerformance
[ ] CommunityToolkit.Mvvm (aka MVVM Toolkit)

Nuget package version(s)

Doesn't matter

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item