ben18785
commented
2 years ago Yep, re:
This is more of a side note, but I do wonder if writing all of the functions (and functions inside functions) in the vignette is going to be super helpful for someone who is new to epidemiology and potentially new to R. Of course, there is great benefit to writing code this way but it takes a lot longer to understand the flow, especially for someone new to this. Since the vignette is something people actually read, as opposed to the classes that are more behind the scenes, I would tend to try and keep the code as simple and easy to understand as possible. No need to change anything, just something to think about.
I completely agree. I think keeping long functions to a minimum is worthwhile. Here, there are a few, I admit, which are due mainly to a) finding a beta value that matches a given R0 value and b) running simulations across the combinations of variants and scenarios. It might be possible at some later date to make a function which automates finding a beta value to achieve a given R0, but let's leave that for now I reckon.
Addresses #70
No tests yet as awaiting feedback on model