ComodoSecurity / openedr

Open EDR public repository
Other
2.19k stars 434 forks source link

Build Instructions #3

Open DefenceLogic opened 3 years ago

DefenceLogic commented 3 years ago

Dear Sirs,

Please explain how it is possible to contribute to this project?

I ask because it implies it is "open", however it requires the madhookcode library which you have to purchase at http://www.madcodehook.com/madCodeHookDescription.htm

I will try contacting the developer directory.

ComodoMelih commented 3 years ago

if you use the binary we have here, then you don't have to pay for madhookcode as far as I know.

pixelsquared commented 3 years ago

@ComodoMelih The issue is how can we build and test changes to OpenEDR if we can't build it without a closed source paid library.

I think that the best solution might be to work to remove the madhookcode library as a dependency.

ComodoMelih commented 3 years ago

I think that the best solution might be to work to remove the madhookcode library as a dependency. agreed! Lets add this to our list.

ozercomodo commented 3 years ago

I am trying to arrange some agreement between madhook developer and openEDR so that we can give the code to all our contributors

pussinboots1992 commented 3 years ago

I am trying to arrange some agreement between madhook developer and openEDR so that we can give the code to all our contributors

This would be great, it will indeed be hard to contribute to this awesome project without having everything required to build it...

Out of curiosity, why did you chose madcodehook's library instead of something like detours for hooking API's ? What made you go for madcodehook ?

trylab commented 3 years ago

NetFilter SDK is also a commercial product which was used in the network monitor driver.

cikgufatah commented 3 years ago

NetFilter SDK is also a commercial product which was used in the network monitor driver.

Yeah, some of the openedr code referring to non existing function at NetFilter SDK. Example: https://github.com/ComodoSecurity/openedr/search?q=cmdedr

muse117 commented 3 years ago

Many source files are missing, resulting in failure to compile.

fcode520 commented 2 years ago

There is no independence between the commercial source code and the source code developed by oneself. There are many public resources in the available section, you can look at the code. Cannot compile and debug.

nealmcb commented 2 years ago

Note also the unresolved issue Stop calling it Open Source if you only provide Commons Clause license · Issue #4 · ComodoSecurity/openedr.