search

Comon-tech / numQuest

Let's turn a simple number guessing game to somtheing big
https://comon-tech.github.io/numQuest/
GNU General Public License v3.0
3 stars 5 forks source link

Incorrect defer attribute in script tag #27

Closed SimonStnn closed 9 months ago

SimonStnn commented 9 months ago

@C-o-m-o-n I see you added the following to index.html.

https://github.com/Comon-tech/numQuest/blob/70a8aa85ce24f6adda146ea07fbc51d5d269de39/index.html#L9

The difer attribute is not correct. It should be defer. Here is the correct notation:

<script src="./resources/js/index.js" type="module" defer></script>

This will make sure the script is correctly deferred and loaded after the page has finished parsing.

This is a followup on #24.

C-o-m-o-n commented 9 months ago

@C-o-m-o-n I see you added the following to index.html.

https://github.com/Comon-tech/numQuest/blob/70a8aa85ce24f6adda146ea07fbc51d5d269de39/index.html#L9

The difer attribute is not correct. It should be defer. Here is the correct notation:

<script src="./resources/js/index.js" type="module" defer></script>

This will make sure the script is correctly deferred and loaded after the page has finished parsing.

This is a followup on #24.

OH, That must have been a typo. Sorry