Comp-490-TR-Afternoon-Group-Four / thefuck

Magnificent app which corrects your previous console command.
MIT License
0 stars 0 forks source link

extract constants to const file, separate logs.confirm_text function,… #13

Closed RyanCallahan312 closed 3 years ago

RyanCallahan312 commented 3 years ago

… remove confirmation log function, add env variable for double confirms

Moved the constants declared in the fix_command file to the dedicated constants file.

seperated the command_text file into two different functions so that there isn't another check for if its in the double confirm dict

moved double confirm logic from fix_command into select_command in the ui. I think this would make more sense because the underlying program shouldn't really care about confirmations.

making double confirm off by default with a environment variable required to turn it on. This might be helpful if we try to make a pr for this in the main repo.

update readme to reflect this

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 723915589


Changes Missing Coverage Covered Lines Changed/Added Lines %
thefuck/entrypoints/fix_command.py 1 2 50.0%
thefuck/logs.py 2 3 66.67%
thefuck/ui.py 7 14 50.0%
<!-- Total: 11 20 55.0% -->
Totals Coverage Status
Change from base Build 720866992: 0.08%
Covered Lines: 6759
Relevant Lines: 7238

💛 - Coveralls