search

CompCogNeuro / sims

Simulations for the Computational Cognitive Neuroscience textbook
https://compcogneuro.org
BSD 3-Clause "New" or "Revised" License
139 stars 52 forks source link

Unit names don't align with units #1

Closed StephenJRead closed 5 years ago

StephenJRead commented 5 years ago

This may not have been implemented yet, but I notice that the unit names on the network do not align with the units. Also, I don't see where the names for the units are defined anywhere, so I was curious how that was done.

rcoreilly commented 5 years ago

It is done by adding labels separately -- see ConfigNetView method. unit names are not included in the core api to keep things simpler, and labels are much more flexible. but as you note, the alignment is only approximate. on my system it is still aligned closely enough that it is usable -- please post screenshot if otherwise on yours.

StephenJRead commented 5 years ago
Screen Shot 2019-08-31 at 7 37 56 PM
rcoreilly commented 5 years ago

Looks like a mac -- retina display? It turns out that when I run on my mac laptop's native display (instead of external monitor I usually use) I replicate this bug, although it is slightly different. Thanks for the report.

StephenJRead commented 5 years ago

I have a Mac 13 inch 2018 MacBook Pro. But I’m pretty sure the screenshot is on my LG external monitor. I tried changing the resolutions around, and it actually does change how well they line up, but I can’t find a resolution where they line up sufficiently well.

On Aug 31, 2019, at 9:10 PM, rcoreilly notifications@github.com<mailto:notifications@github.com> wrote:

Looks like a mac -- retina display? It turns out that when I run on my mac laptop's native display (instead of external monitor I usually use) I replicate this bug, although it is slightly different. Thanks for the report.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_CompCogNeuro_sims_issues_1-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAFASMS3PBSGUGZHLXX3XRSDQHM6DFA5CNFSM4ISSOMM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TZ4RI-23issuecomment-2D526884421&d=DwMCaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=u9vxqOpfdB9xqeWwZKwBWw&m=Asrea8kfx8YSeNoOccp4OngzM8AzvdJlr-N15bZx36M&s=CMQ-_IXRSCvCvOFMKI0HZgQDwJHlBD3SxHTVTm1vPbw&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AFASMS4JNHE3IYZRRBST2BDQHM6DFANCNFSM4ISSOMMQ&d=DwMCaQ&c=clK7kQUTWtAVEOVIgvi0NU5BOUHhpN0H8p7CSfnc_gI&r=u9vxqOpfdB9xqeWwZKwBWw&m=Asrea8kfx8YSeNoOccp4OngzM8AzvdJlr-N15bZx36M&s=jbNtI3MxNHT5iOxnm9LuEwVZFVXFsh4T1jjGfQCp2Gk&e=.

rcoreilly commented 5 years ago

fixed -- was doing word wrapping -- set style to stick to label format