search

CompEvol / BeastFX

GUIs for BEAST using Java FX to make things more pretty.
GNU Lesser General Public License v2.1
4 stars 2 forks source link

Fixed command line argument parsing problem. #51

Closed tgvaughan closed 1 year ago

tgvaughan commented 1 year ago

This patch addresses another command line argument parsing problem. Previously, the inner loop used to process 0 or more arguments to -version_file was incrementing the index too many times, causing other arguments to be missed.

rbouckaert commented 1 year ago

Thanks Tim!

I now routinely use -version_file /path/to/workspace/* or -version_file ../* which picks up all version.xml files in subdirectories of /path/to/workspace/ or ../ respectively, which loads more than I want, but save me to specify files for each dependent package.

tgvaughan commented 1 year ago

Hi Remco, thanks for merging - and thanks for the heads up re the globbing syntax of -version_file, that's very useful! Is this also implemented in BeastMain?

By the way, the above patch contained a not-so-subtle bug. I forgot that BeautiDoc does further processing of the arguments after the loop I changed in BeautiTabPane, meaning that the skipping of unknown arguments causes valid arguments such as "-template" and "-nex" to also be skipped. Sorry for being so sloppy!

Since this PR is already merged I can't modify it, but I'll open another to fix this.