Inconsistent labelling of partitions in priors panel

CompEvol / BeastFX

GUIs for BEAST using Java FX to make things more pretty.

GNU Lesser General Public License v2.1

4 stars 1 forks source link

Inconsistent labelling of partitions in priors panel #57

Open tgvaughan opened 1 year ago

tgvaughan commented 1 year ago

For partitions which have been relabeled, it seems BEAUti (2.7.4) still uses the old names in the parameter descriptions in the priors panel: Screenshot 2023-06-08 at 17 38 46

rbouckaert commented 1 year ago

@tgvaughan I am not completely sure what the expected behaviour is. For the example you gave, there are two things that can be relabeled: the alignment name and the site model name. After renaming the site model, the name displayed will be the renamed site model if the label is of the form s:$(n) and is the name of the alignment is it is $(n). The BeautiDoc.renamePartition() method takes care of renaming. Is this not what is expected?

tgvaughan commented 1 month ago

Hi Remco, sorry for letting this issue go stale. And you're absolutely right. I think I was just confused by the presence of the "s:" prefix in the partition name. Would it make sense to drop that prefix?