CompImg / LST-AI

LST-AI - Deep Learning Ensemble for Accurate MS Lesion Segmentation
https://doi.org/10.1016/j.nicl.2024.103611
MIT License
18 stars 4 forks source link

Potential Bug : `space-FLAIR` vs `space-flair` #20

Open jqmcginnis opened 3 weeks ago

jqmcginnis commented 3 weeks ago

Hey,

I just noticed that we are not using consistent space-flair vs space-FLAIR file name labels. Is this intentional to distinguish between the prob masks, or just an oversight?

Check the filenames here: https://github.com/CompImg/LST-AI/blob/2c350eb9688af5758969f29a1ff1a1f215f289bf/LST_AI/lst#L168

and e.g.: https://github.com/CompImg/LST-AI/blob/2c350eb9688af5758969f29a1ff1a1f215f289bf/LST_AI/lst#L148

For backwards compatibility, I would likely keep the space-flair - or what do you think?

twiltgen commented 3 weeks ago

Hey, ohh yeah, I used space-FLAIR in the newly added lines for the probability map since I'm used to that convention. But feel free to change it back to space-flair :)