ryoherisson commented 3 years ago

Summary

Implement the common function _gamma_select as follows:

    def _gamma_select(self, gamma, overlap):
        if gamma == "one":
            return 1.0
        elif gamma == "reciprocal":
            if overlap > 1:
                return 1.0 / overlap
            else:
                return 1.0
        elif gamma == "udf_gamma":
            if overlap > 1:
                return 1.0 / self._udf_gamma(overlap)
            else:
                return 1.0

Goal

Make it possible to select the gamma value according to the parameters.

Todo

[X] Implement the function: InterfaceTimeSeriesMetrics._gamma_select()
[X] Check if the unit tests are passed

Deadline

yyyy / mm / dd

Parent issue

11

References

If there are any reference links, they are described here.

Notes

Other comments.

ryoherisson commented 3 years ago

utestで、W292 no newline at end of file と出るので、各ファイル最後に空行追加しておく必要あり

nocotan commented 3 years ago

@ryoherisson LGTM

sarrrrry commented 3 years ago

@ryoherisson

Issue消化ありがとうございます！ mergeされた後で申し訳ないのですが、 Interfaceには実装を記述するのは運用の想定と違うため以下のいずれかに修正おねがいできますでしょうか？

_gamma_selectをそれぞれのクラスで実装する
Interfaceと各個クラスの間に親クラスを作ってそこに実装する
InterfaceじゃなくてBaseに書き換える

参考: Interfaceとは