CompPhysVienna / n2p2

n2p2 - A Neural Network Potential Package
https://compphysvienna.github.io/n2p2/
GNU General Public License v3.0
217 stars 82 forks source link

changed regex seperation in sed for makefile. #106

Closed DanielMarchand closed 2 years ago

DanielMarchand commented 3 years ago

Fixes a bug where it was impossible to make if the branch name had forward slashes (/). I changed the regex separator to plus signs (+) because I think these are almost never used in branch naming. Of course, the ultimate way to solve this bug would be to perhaps to strip all special symbols first but this should work for now.

singraber commented 2 years ago

Sorry for taking so long for merging this.. I switched the delimiter to '?' because it seems it's forbidden in Git branch names anyway. Thanks for catching this!