search

CompPhysVienna / n2p2

n2p2 - A Neural Network Potential Package
https://compphysvienna.github.io/n2p2/
GNU General Public License v3.0
217 stars 82 forks source link

Work around MPI compilation failures when cross-compiling LAMMPS to Windows #130

Closed akohlmey closed 2 years ago

akohlmey commented 2 years ago

This change casts MPI_Pack()/MPI_Unpack() argument pointers to void * to work around compilation failures with mingw64 cross compilers on Linux. We're currently working around this with running sed on the source file before compiling.

codecov-commenter commented 2 years ago

Codecov Report

Merging #130 (8403134) into master (d66d982) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   72.28%   72.28%           
=======================================
  Files         130      130           
  Lines       14231    14231           
=======================================
  Hits        10287    10287           
  Misses       3944     3944
Flag Coverage Δ
cpp 75.07% <0.00%> (ø)
python 72.28% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/libnnpif/LAMMPS/InterfaceLammps.cpp 61.31% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d66d982...8403134. Read the comment docs.