No name for plannar on setup screen

[jteplitz]

When you create a new account you get sent to the preferences screen where you set your name. But since you haven't set a name yet the header shows 's planner. We should not show that.

[mattdailis]

Hmm...actually, doesn't the "Sign up" form ask for the name at the moment? (I don't know whether it will once Radiant redesigns the front page)

[jteplitz]

It does ask for it, but it doesn't require it.

On Sat, Oct 6, 2012 at 9:04 AM, Matt notifications@github.com wrote:

Hmm...actually, doesn't the "Sign up" form ask for the name at the moment? (I don't know whether it will once Radiant redesigns the front page). Doesn't seem buggy to me at the moment.

— Reply to this email directly or view it on GitHubhttps://github.com/CompSciClub/Hopkins-Planner/issues/15#issuecomment-9197967.

Jason Teplitz

[ama291]

this has been corrected

[jteplitz]

Been corrected in what?

[ama291]

its fixed already

[jteplitz]

How so?

[ama291]

When you create a new account and get sent to the preference screen, it shows your name.

[jteplitz]

Not if you didn't enter one. The bug is that you don't have to enter one in the setup dialog.

[ama291]

Ah. Ok I will try to fix that.

[ama291]

It is fixed, the name is blank.

[jteplitz]

It shouldn't let you not enter a name. The bug is that it does. 's Planner should never be in the header.

[ama291]

What should it say then?

[ama291]

Ok, I think I fixed this on my forked repo.

[jteplitz]

Great. Can you submit a pull request?

On Thu, Oct 11, 2012 at 7:24 PM, Ama291 notifications@github.com wrote:

Ok, I think I fixed this on my forked repo.

— Reply to this email directly or view it on GitHubhttps://github.com/CompSciClub/Hopkins-Planner/issues/15#issuecomment-9361823.

Jason Teplitz

[jteplitz]

Fixed in refactor branch. We may need to make the client side a little cleaner when handling this. But the core issue is fixed.