search

CompSciLauren / stardew-valley-daily-screenshot-mod

:honeybee: A Stardew Valley mod that automatically takes a screenshot of your entire farm at the start of each day
https://www.nexusmods.com/stardewvalley/mods/4779
MIT License
10 stars 9 forks source link

Screenshot taken one day later than assigned day in config #45

Closed CompSciLauren closed 10 months ago

CompSciLauren commented 3 years ago

Description of Bug From user post on Nexus, "Screenshots being taken a day after the set "Days" value in the config" reported on 23 May 2020: https://www.nexusmods.com/stardewvalley/mods/4779?tab=bugs&BH=1

I set mine to "Sundays, AnySeason" but for some reason it only takes the screenshot at Monday mornings. I've tried changing it to other days but the same thing happens (it happens the day after the set value).

SMAPI log: https://smapi.io/log/85ee94c4613f4d93acd5fd1e8b5a06fc

Steps to Reproduce Steps to reproduce the behavior:

  1. Set the day for the screenshot to be taken to any particular day of the week in the config
  2. In-game, see that the screenshot is not taken on the designated day. Then the next in-game day, see that the screenshot is taken.

Expected behavior Screenshots should be taken on the exact day specified by the user in their config file.

CompSciLauren commented 3 years ago

Posting this Issue for documentation purposes, but I believe the code to fix this is already written (just need to test it again and make sure everything looks good).

This issue was caused due to the starting day of the week being incorrect in the code. In Stardew Valley, the first day of the week is a Monday and the last day is Sunday. However, the code represents the first day of the week as Sunday with the last day being Saturday. Again, this should already be fixed if I recall from when I was last able to work on the mod, just need to test it and make any changes if needed.

CompSciLauren commented 10 months ago

Possibly related, "The weekday setting doesn't work." reported on Nexus originally on 24 Jul 2022: https://www.nexusmods.com/stardewvalley/mods/4779?tab=bugs&BH=1

CompSciLauren commented 10 months ago

This is now completed and has been added as part of the 3.0 release! Closing.