Closed f3wer closed 3 years ago
Hey, first off thank you so much for working on this and creating a PR! Fantastic stuff. I'm reviewing the changes and testing things out, I'll try to finish reviewing this soon.
Just wanted to respond to your "things to consider" section:
Finished reviewing, looks great and is now merged! Thanks again for your efforts. Decided that I'll go ahead and see if I can add the other config options before we release the next update. Added issue #48 to help track this.
- Sorry I don't think I understand what you're referring to here. Can you please explain a bit more? What constant default values are you referring to, and what do you mean by "settable within range"?
To be honest, I don't know what I meant. I think we can ignore this point.
… in og repo.
Summary
Therefore added 3 new boolean fields in the
ModsConfig.cs
class and altered theOnGameLaunched
method inModEntry.cs
. I used the this example code to implement this changes.Things to consider
Thread.Sleep
operation at line 687 inModEntry.cs
necessary; or could it also be made configurable to setMILLISECONDS_TIMEOUT
"dynamically" to potentially avoid lag everytime a screenshot is taken?Testing
I compiled and ran the game without any problems. The newly added features seemed to be working. Due to the fact that this is my first mod edit and pull request, I just wanna' stress that you may take a closer look.