search

CompSciLauren / stardew-valley-daily-screenshot-mod

:honeybee: A Stardew Valley mod that automatically takes a screenshot of your entire farm at the start of each day
https://www.nexusmods.com/stardewvalley/mods/4779
MIT License
10 stars 9 forks source link

Add additional unit tests (ongoing) #57

Open CompSciLauren opened 10 months ago

CompSciLauren commented 10 months ago

Is your feature request related to a problem? Please describe. Unit tests are helpful for validating that the mod works as expected, instead of having to only rely on manual testing.

Describe the solution you'd like Add unit tests for this mod. Can cover anything.

Describe alternatives you've considered None.

Additional context This Issue was originally about adding unit tests for the first time for this mod. A few initial tests have now been added. Feel free to submit a PR to add onto the existing unit tests! Will just leave this Issue open for some time, since it's always helpful to have better testing.

Jilesh980 commented 10 months ago

hi @CompSciLauren can i add one unit test for this and contribute to the project. Thank you

CompSciLauren commented 10 months ago

Hi @Jilesh980 yes thank you, that would be wonderful! Even just one working test would be helpful as a starting point. Let me know if you need anything or have questions. And please be sure to add your name to the Contributors.md file! Thanks :)

JoshJOkayguy commented 10 months ago

@Jilesh980 Have you already forked the project and implemented a framework? Would be nice to have a pr that just contains the basics for the tests so we can work in tandem here.

CompSciLauren commented 10 months ago

@Jilesh980 @JoshJOkayguy thank you both for wanting to help! Just wanted to give a quick update. @dv297 submitted PR #74 which has been merged to master. It contains basic changes needed to get started plus a few unit tests.

Feel free to submit a PR if you want to add onto it. I think I'll just update this Issue to be about unit testing in general and leave it open for some time. Thanks again!