Make Module Installable Via Composer

CompactCodeEU / FixProductBreadcrumbs

This is a Fix for Magento 2.2.4 and 2.2.5 where the Product Breadcrumbs are generated with JS normally and contain unwanted text.

GNU General Public License v3.0

32 stars 13 forks source link

Make Module Installable Via Composer #1

Closed NathanDayMF closed 5 years ago

NathanDayMF commented 5 years ago

Background

As a Developer I would like to be able to install this Module via Composer

UAC

[ ] Module is install by composer

Suggested fix

move composer.json file to repository root
change FixProductBreadcrumbs directory name to src
modify composer.json
- line 21 to be `"src/registration.php"'
- line 24 to be "CompactCode\\FixProductBreadcrumbs\\": "src"
- Remove "extra" array (line 27 - 34)
Update Readme with Composer Install Instructions

## Composer Install Instructions
composer config repositories.compact-code-fix-product-breadcrumbs git git@github.com:CompactCodeEU/FixProductBreadcrumbs.git
composer require compactcode/fixproductbreadcrumbs: "dev-master"
php bin/magento setup:upgrade

CompactCodeEU commented 5 years ago

@NathanDayMF Sure no problem. I will complete this task today.

CompactCodeEU commented 5 years ago

@NathanDayMF Can you confirm that this is correct now?

andrsan commented 5 years ago

tried installing but gives an error:

Skipped branch master, "'a7fd4225ada0e1b556a4c67d0bce851f4031dfa0':composer.json" does not contain valid JSON
Parse error on line 26:
}   },     }
-------------------^
Expected: 'STRING' - It appears you have an extra trailing comma
  [Composer\Repository\InvalidRepositoryException]
  No valid composer.json was found in any branch or tag of git@github.com:CompactCodeEU/FixProductBreadcrumbs.git, could not load a package from it.

can you check it out? thank you

CompactCodeEU commented 5 years ago

Should be fixed now

andrsan commented 5 years ago

Not yet! I've made a pull request with the proposed fixes. Thank you.

CompactCodeEU commented 5 years ago

Ok i see. Thanks for the help! I accepted the pull request. I will close this. If any problems still occur please open a new issue. Again thanks for the help.