CompanyGateways / mytracks

Automatically exported from code.google.com/p/mytracks
1 stars 0 forks source link

Remove locations ArrayList from Track parcelable #429

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Mercurial clone with changes to be reviewed:
https://bhardill-mytracks.googlecode.com/hg/ 

Revisions to be pulled from that clone (or "all"):
faf8bed08012

http://code.google.com/r/bhardill-mytracks/source/detail?r=faf8bed08012181d2f307
2bc0a2af6cd48bd7f7f

Purpose of code changes on the clone:
Remove the writing of locations ArrayList to the Track parcelable as it's no 
longer used and causes a ArrayIndexOutOfBoundsException

When reviewing my code changes, please focus on:
/MyTracksLib/src/com/google/android/apps/mytracks/content/Track.java

This was found as a result of the changes in the following review item
http://code.google.com/p/mytracks/issues/detail?id=419

Original issue reported on code.google.com by b.hard...@gmail.com on 25 Apr 2011 at 11:20

GoogleCodeExporter commented 9 years ago
Moved it to a totally new clean clone

https://bhardill-export-track.googlecode.com/hg/

Revision
f35dbbe86d61

http://code.google.com/r/bhardill-export-track/source/detail?r=f35dbbe86d616e415
61839a2316867b8e7e68d88

Original comment by b.hard...@gmail.com on 25 Apr 2011 at 11:50

GoogleCodeExporter commented 9 years ago
LGTM

That clone does not seem to have commenting enabled.  I'll push to head when I 
get a chance.

Original comment by sandordo...@google.com on 25 Apr 2011 at 11:56

GoogleCodeExporter commented 9 years ago
Sorry it's getting late here.

Comments now on

Original comment by b.hard...@gmail.com on 25 Apr 2011 at 11:59

GoogleCodeExporter commented 9 years ago

Original comment by sandordo...@google.com on 26 Apr 2011 at 3:40