Zephyr HxM small update

[GoogleCodeExporter]

Mercurial clone with changes to be reviewed:
http://code.google.com/r/nic-sensors/source/browse

Revisions to be pulled from that clone (or "all"):
all

Purpose of code changes on the clone:
- using cadence data from Zephyr HxM
- CRC8 calculation and check for HxM payload

When reviewing my code changes, please focus on:

Original issue reported on code.google.com by n...@nclm.de on 9 May 2011 at 8:00

[GoogleCodeExporter]

So you need to set allow reviews to true for us to comment on this.  I started 
to integrate your changes.  I cleaned up the code a bit but Rodrigo still found 
13 things to complain about.  It would be great if you could address all of his 
comments here:
http://code.google.com/r/sandordornbush-patches/source/detail?r=3dfdbcf78de082ed
b66a8994ffb604c84945df0d

Original comment by sandordo...@google.com on 9 May 2011 at 5:43

• Changed state: Accepted

[GoogleCodeExporter]

I enabled "Allow non-members to review code".

So after you already cleaned up the code, where shall I address the comments? 
In my clone?

Original comment by n...@nclm.de on 9 May 2011 at 6:27

[GoogleCodeExporter]

Yes probably a good place to start is to copy the files from my clone.  [You 
can hg pull from it or just download the page from the code site.]  Then 
address Rodrigo's comments.

I would really appreciate it if you can do the change as I don't currently have 
a Zehpyr so I cannot actually test the code.

Original comment by sandordo...@google.com on 9 May 2011 at 7:30

[GoogleCodeExporter]

I have updated the code in my repository clone. Few of the code proposals 
haven't been a good idea, so they are ignored. Working with bit shifts and xors 
on bytes result in implicit casts to (signed) ints in Java (this is where 
depending on the sign 1s or 0s are introduced during a cast to int). This makes 
it hard when expecting the results of this examples. Thus, I used 0xFF masks to 
compensate that and switch all bytes other than the first one to 0.

Original comment by n...@nclm.de on 11 May 2011 at 9:46

[GoogleCodeExporter]

Original comment by sandordo...@google.com on 19 May 2011 at 8:05

• Changed state: Fixed