ComparativeGenomicsToolkit / cactus

Official home of genome aligner based upon notion of Cactus graphs
Other
523 stars 111 forks source link

fix gfaffix dont_collapse regex #1225

Closed glennhickey closed 1 year ago

glennhickey commented 1 year ago

I have a bad habit of confusing *s like in bash with actual regexes. This lead to a longstanding bug in the gfaffix invocation that would potentially select more than the reference paths for --dont_collapse. Since it only ever checks that the reference path didn't get collapsed, this went unnoticed until I publicly humiliated myself.

I don't think this bug would have too detrimental of an effect on most graphs -- it would just prevent collapsing of a duplication that otherwise would be zipped in certain very specific circumstances where all characters in the reference sample appear in another path name.