ComparativeGenomicsToolkit / cactus

Official home of genome aligner based upon notion of Cactus graphs
Other
505 stars 112 forks source link

Fix bug introdued with new memory environment variables #1309

Closed glennhickey closed 6 months ago

glennhickey commented 6 months ago

I hacked this logic (#1283, #1292) in when struggling with some T2T alignments on Slurm, but clearly didn't test it enough since it completely broke cactus on AWS/MESOS. The reason is that it's using (and int-casting) options.maxMemory and options.defaultMemory from Toil, which default to None on AWS/MESOS (but not single machine and slurm where I was testing).

Anyway, this PR should fix it, buy handling None values (and making sure that passed-in values are properly parsed).