Closed glennhickey closed 6 months ago
I fixed the makefile, builds fine on my machine. But the Python build is messed up by the inclusion of abPOA. I'm not quite sure the right way to fix it.
Can you try building the Python part on your machine?:
actually, maybe if I remove the merge_adjacent_alignments and have that in a separate header file we can keep a separation from the code in the python library...
oof, yeah I hadn't quite gotten to the python build. I'm getting a fatal error: abpoa.h: No such file
which I imagine is your problem too? Taking a look now...
Okay.. this all works on my mac (i.e. builds/tests okay)
This replaces the wfa-based gap sequence aligner with abPOA. The default cactus scoring parameters are hardcoded in. It passes all tests but I haven't yet tested it at scale. In particular it will only work to about ~100kb -- should be fine in practice but at the very least needs an explicit check.
@benedictpaten do you mind testing it builds and runs for you?
As an aside, it wouldn't even pass the tests until I sorted the abpoa input by length -- the problem case is below:
but sorting works