Compass / compass-rails

compass rails integration

MIT License

591 stars 276 forks source link

Scss partials not reloading when compass-rails is present #210

Closed Intrepidd closed 9 years ago

Intrepidd commented 9 years ago

This seems related to rails/sass-rails#269

Steps to reproduce

Clone the repository https://github.com/Intrepidd/compass-rails-reload-bug
bundle install
launch rails server and go to http://localhost:3000/home/index
change color in test/home.scss file
reload your page, it should NOT change
rm -rf tmp/cache
remove compass-rails from gemfile
try again, this time it SHOULD work

craigmcnamara commented 9 years ago

I think it's one of the patches that I just took in to master. I'm able to reproduce it and to verify that it's a compass-rails regression.

Intrepidd commented 9 years ago

good, we're close to sort this out then :)

craigmcnamara commented 9 years ago

Ok, so I've been hammering on this and here's what I know from my Rails 4.1 app. Compass-rails 2.0.0 works fine and it uses Compass 0.12.x. I can't boot my Rails 4.1 app on compass-rails 2.0.1 which is the update to Compass 1.0.0. When I boot on the master branch of compass-rails partials don't recompile without changing the stylesheet that imports them. I had suspected a pull request that I recently landed was the culprit but when the patch was removed I have the same problem.

/cc @chriseppstein @scottdavis

scottdavis commented 9 years ago

Sasscache issue?

Sent from my iPhone

On Dec 31, 2014, at 3:12 PM, Craig McNamara notifications@github.com wrote:

Ok, so I've been hammering on this and here's what I know from my Rails 4.1 app. Compass-rails 2.0.0 works fine and it uses Compass 0.12.x. I can't boot my Rails 4.1 app on compass-rails 2.0.1 which is the update to Compass 1.0.0. When I boot on the master branch of compass-rails partials don't recompile without changing the stylesheet that imports them. I had suspected a pull request that I recently landed was the culprit but when the patch was removed I have the same problem.

/cc @chriseppstein @scottdavis

— Reply to this email directly or view it on GitHub.

craigmcnamara commented 9 years ago

@Intrepidd So, I'm having some trouble with this it looks like we're not properly tracking asset dependencies, but I don't know where to look. I'm going to keep at it, but if you know more about Sass-rails I'd appreciate the help.

danielpclark commented 9 years ago

See #208

Intrepidd commented 9 years ago

I don't know much about the code of compass-rails and sass-rails but I'll try to have a look

On Sat, Jan 3, 2015, 05:33 Daniel P. Clark notifications@github.com wrote:

See #208 https://github.com/Compass/compass-rails/issues/208

— Reply to this email directly or view it on GitHub https://github.com/Compass/compass-rails/issues/210#issuecomment-68583023 .

Intrepidd commented 9 years ago

@danielpclark , I had a quick read through the code of sass-rails and compass-rails and indeed, I think you may be onto something :)

It was probably done otherwise before, but right now, in the evaluate method of the sass template that we override, we're not setting the dependencies as it's done in sass-rails

craigmcnamara commented 9 years ago

Give master a try, it works in my rails 4.1 app, but I have some older ones to test and I'll be adding more testing of the compilation step on the master branch.

jfairbank commented 9 years ago

@craigmcnamara, I was having the same issue here. I just pulled master, and it looks like it is working for me with sass-rails 5.0.1. I edited a partial, refreshed, and the changes showed up in my stylesheet and app.

craigmcnamara commented 9 years ago

I just cut 2.0.2.