search

Compass / compass-rails

compass rails integration
MIT License
592 stars 277 forks source link

Support Rails 6.0, and drop 3.x, 4.x, 5.0 and 5.1 #280

Closed yhirano55 closed 4 years ago

yhirano55 commented 4 years ago

Summary

I've maintained CI configuration, because our legacy project depends on this gem. And we need to safely merge #279. It seems that framework versions is too old in travis config. So I've updated them.

Support Rails versions:

Drop Rails versions (these are not maintained by rails):

In addition, I also have updated Ruby version in travis config:

Currently, Ruby 2.3 or ealier series are not supported. So I've dropped them. Thanks.

yhirano55 commented 4 years ago

According to Rails Guide, it seems that v4.2 and 5.0 and 5.1 have also already been unsupported versions. So I'm going to drop them in CI config.

yhirano55 commented 4 years ago

@craigmcnamara I guess this compass-rails is hardly maintained, but some projects (includes our legacy project) still use it, would you please review this patch?

yhirano55 commented 4 years ago

@scottdavis @chriseppstein Could you review this pull request?

prateekkish commented 4 years ago

Bump! Could someone review this PR?

@scottdavis @chriseppstein

craigmcnamara commented 4 years ago

It's been years since I've used Compass, but since you guys did the legwork I've merged the pull request and cut release 4.0.0. You can update your Gemfile and try your handiwork.