search

Compass / compass

Compass is no longer actively maintained. Compass is a Stylesheet Authoring Environment that makes your website design simpler to implement and easier to maintain.
http://compass-style.org
Other
6.72k stars 1.18k forks source link

Sprite images with names matching color names replaced with color value #1240

Open RobinDaugherty opened 11 years ago

RobinDaugherty commented 11 years ago

I have some sprites declared. Some of the sprites have images named "white", "yellow", etc.

In development, these sprites work perfectly. When I turn on compression, the sprite class names that correspond to these images change from (for example) "icon-white" to "icon-#fff". Of course, these selectors are not valid.

Two issues I found in the compass project give me some clue: #381 and #910. This comment seems to point out the culprit: https://github.com/chriseppstein/compass/commit/84d207f8277a0456adf21e18468dea7408cff53a#commitcomment-378039

scottdavis commented 11 years ago

What compass version are you using? I'm pretty sure this was fixed as you can see here https://github.com/chriseppstein/compass/blob/master/lib/compass/sass_extensions/functions/sprites.rb#L249-L250

RobinDaugherty commented 11 years ago

Wow sorry, I can't believe I left that out. I'm using 0.12.2, which includes the lines you're looking at there.

scottdavis commented 11 years ago

Ugh ok ill add it to my list

Sent from my iPhone

On Apr 1, 2013, at 11:16 PM, Robin Daugherty notifications@github.com wrote:

Wow sorry, I can't believe I left that out. I'm using 0.12.2, which includes the lines you're looking at there.

— Reply to this email directly or view it on GitHub.

Aradesh commented 10 years ago

This bug is reproduced in 1.0.0 too

chriseppstein commented 10 years ago

@Aradesh Thanks for the heads up.