search

ComplementaryDevelopment / ComplementaryReimagined

Complementary is a graphical rework pack for Minecraft with exceptional quality, detail, and performance.
https://www.complementary.dev/shaders/
Other
181 stars 50 forks source link

Handheld light bug 1.12.2 #114

Open G1ll0u opened 2 months ago

G1ll0u commented 2 months ago

Hello,

Here's my problem running R5.2.2 on Optifine G6 pre1 1.12.2 : Video

As you can see there is a weird handheld light bug that disappears after disabling this last.

Here's a demonstration of the same bug but on V4.7.2 :

Video

You can see that the problem is the same but without this masive glare. Is it caused by 1.12.2 items ID system ? the famoso that changed with 1.13 ? link

Have a nice day !

G1ll0u commented 2 months ago

Or... Is there a way by extracting your shaderpack to edit a file that allow items to emit light in-hand or not ?

EminGT commented 1 month ago

Um I have no idea why this is happening to be honest. The light emitting items aren't a list in the shaderpack. They are provided by Optifine/Iris

G1ll0u commented 1 month ago

Optifine... I really hope there will be an alternative to Optifine like Iris for 1.12 one day. For now, that's not a too big problem but for V5 and this first "ultra lighting" bug, do you think it can be fixed ?

I really love v5, I had to downgrade to v4 due to SSS on foliage being weird and this first bloom bug. Oh and the first bloom bug doesn't appear with torch item. With torch item, the light emits normally.

I'll create a ticket to describe the foliage SSS problem soon.

Le mar. 16 juil. 2024, 08:59, Emin @.***> a écrit :

Um I have no idea why this is happening to be honest. The light emitting items aren't a list in the shaderpack. They are provided by Optifine/Iris

— Reply to this email directly, view it on GitHub https://github.com/ComplementaryDevelopment/ComplementaryReimagined/issues/114#issuecomment-2230164015, or unsubscribe https://github.com/notifications/unsubscribe-auth/AITUYICJKL64BPKURAJ35BDZMTAGHAVCNFSM6AAAAABK2SCS32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQGE3DIMBRGU . You are receiving this because you authored the thread.Message ID: <ComplementaryDevelopment/ComplementaryReimagined/issues/114/2230164015@ github.com>

EminGT commented 1 month ago

I think what I can do is discarding the light data given by Optifine if it seems like it's too high