ComplementaryDevelopment / ComplementaryReimagined

Complementary is a graphical rework pack for Minecraft with exceptional quality, detail, and performance.
https://www.complementary.dev/shaders/
Other
185 stars 53 forks source link

Latest build broke Waystones mod feature (missing glyphs) #125

Closed Mister-Curious closed 1 month ago

Mister-Curious commented 2 months ago

Greetings. I recently updated to 1.21 from 1.20.4. Upon launch of the latest game build, and latest Complimentary Shaders (Reimagined), there is a feature from the Waystones mod that is no longer working.

Once a Waysone has been activated, there is a visual layer that becomes present (a luminescent glyph):

image

However when I play the game with shaders activated it longer shows:

image

I contacted the mod author who has been very helpful in diagnosing the issue, however they have mentioned that the only recourse at this point is to contact the folks who maintain the shader mod. It is my hope that we can identify what is causing this to break, and find a fix. I did try almost all of the settings in the shader pack to see if there was something that would reenable the missing glyphs, however I was not able to locate any settings that restored them.

Waystones mod version: waystones-fabric-1.21-21.0.8.jar

Shader Pack version: ComplementaryUnbound_r5.1.1

It should be noted that this all worked fine when I was using previous versions of both mods that were made for 1.20.4.

Thanks for your time.

BlayTheNinth commented 2 months ago

For reference, the code in question:

https://github.com/TwelveIterationMods/Waystones/blob/1.21.x/common/src/main/java/net/blay09/mods/waystones/client/render/WaystoneRenderer.java#L56-L66

EminGT commented 2 months ago

First of all, know that shader packs are not Minecraft version dependant. You can use any version of Complementary in any Minecraft version. With this information I want to ask you a couple things:

Mister-Curious commented 2 months ago

Thanks for the reply. To answer your questions:

Which version of Complementary were you using before?

ComplementaryUnbound_r5.1.1 (it appears to be the same one as am I using now)

Did you try using that older version of Complementary in 1.21 as well to see if it still works?

Since it's the same as mentioned above, then no.

Why not try out the latest version of Complementary (r5.2.2) instead of r5.1.1?

Tried this as suggested, however the issue is still present.

Is there anything else I might try to see if I can get this to work? Perhaps checking out that code that is linked in the previous reply might shed some light. I do not code, so I will not be able to glean anything from that.

Thank you .

Mister-Curious commented 2 months ago

Any chance someone could help with this still?

Mister-Curious commented 1 month ago

Could anyone please provide some assistance? I really want to understand why this problem is happening, and what I might do to rectify the issue. Its been a couple of weeks since I last asked for help.

Thanks

sloraris commented 1 month ago

Here to add my shared experience. Was running 1.20.1, updated to Complementary Unbound r5.2.2 and everything was working fine. Jumped to 1.21 and now the glyphs do not show when shaders are enabled. I've tested every single setting I could find that might be related, along with adjusting other mod's settings for block entities and renderers to no avail. Shaders on, no glyphs. Shaders off, glyphs appear. Would love to have this working again because these waystones look fantastic with Complementary. 2024-08-31_21 30 59 2024-08-31_21 31 06

Mister-Curious commented 1 month ago

Glad its not just me. I ran all the same tests you did, with no results.

BlayTheNinth commented 1 month ago

Seeing that sharestones work, which render in the same manner, I believe the issue is that in Vanilla, the alpha channel of the color is ignored, while with the shader, it's respected.

Sharestones happen to set an opaque alpha, whereas waystones just relied on the alpha channel not being used and so used a color of #FFFFFF instead of #FFFFFFFF.

Please test with Waystones v21.1.3 to see if it solves the issue.

sloraris commented 1 month ago

I finally got a chance to test this, and I can confirm it's working again! Thanks so much to both of you for your awesome work on these incredible projects. 2024-09-06_16 06 33

EminGT commented 1 month ago

Closing as it's fixed by the mod