Reflection aren't rendered when object in the reflection is hidden from view

[Clozent]

When you look at something's reflection on water and move so it is covered by something else, the part of it that is covered will also disappear in the reflection. I have a video recording of it, as an example. https://youtu.be/FTEii9_DIyA

This probably happens any time an object isn't rendered, since if the player doesn't look at an object, it's reflection will disappear as well.

[EminGT]

Hello. This is a limitation of doing fast reflections in Minecraft. The objects that can't be seen by the player cannot be reflected on the water. In your video, leaves of the tree are blocking the terrain that is supposed to be reflected. If this is bothering you, you can change the Water Style option to "Fantasy" to make the problem way less noticeable.

On Mon, Apr 24, 2023 at 9:29 PM Clozent @.***> wrote:

When you look at something's reflection on water and move so it is covered by something else, the part of it that is covered will also disappear in the reflection. I have a video recording of it, as an example. https://youtu.be/FTEii9_DIyA In the video you can also see some weird reflection behaviour (the same location with the first issue mentioned, visible at the start of the video) that doesn't seem to come from this cause.

In short, the reflections are weird.

— Reply to this email directly, view it on GitHub https://github.com/ComplementaryDevelopment/ComplementaryReimagined/issues/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMOZKAV4VXYP3OMBMYHIUGLXC3A7XANCNFSM6AAAAAAXJ6RVYQ . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

[Clozent]

But why? This is really hurting the experience. The "Fantasy" style looks like any other shader's water and the "Reimagined" style is cool and unique. Why not have an option for it? This way, people with more capable computers can turn it on and enjoy better reflections.

[EminGT]

I understand your frustration about this problem, because I am frustrated about it as well. There really isn't a great way to do this in Minecraft. Some effects can't be made an option, and this is one of them. It would cost insane performance (get your current fps and divide it by 2) to even have the option added. I might figure out something else to hide the limitations in the future, but for now this is really the best we can do.

[ghost]

Not that I want this feature but just a question.

I assume halving FPS is caused by implementing something like reflection plane or similar technique. Is Iris capable of over-scanning? Rendering a few extra degree outside of normal FOV just to use the result in SSR?

While this won't solve the issue @Clozent demonstrated, it should still minimize jarring artifact near screen edge.

Again, this is not at all important for me.

[EminGT]

I think some kind of overscan could be added. I need to take a look at the specifics about resolution dropping though. The easy way to do it would reduce the resolution of the image