search

ComplementaryDevelopment / ComplementaryReimagined

Complementary is a graphical rework pack for Minecraft with exceptional quality, detail, and performance.
https://www.complementary.dev/shaders/
Other
185 stars 53 forks source link

Feature Request: Curio/Trinket support for dynamic lighting #51

Closed son0fether closed 12 months ago

son0fether commented 12 months ago

Hello there, this is a fantastic shader and I love it.

I particularly appreciate the built-in very fast dynamic lighting from the off-hand slot. Would it be too much trouble to include curio and trinket slots for dynamic lighting as well?

This might involve querying the curios/trinkets mods at startup for which slots exist. I'd understand if that would be too much, but it would be really fun.

Example datapack that lets you put a torch on your head with Curios: data/curios/tags/items/head.json -> { "values": [ "minecraft:torch" ] }

For dynamic lighting mods, the following mod provides a solution, but it looks like a shaderpack with dynamic lighting would have to add the change itself:

EminGT commented 12 months ago

Shaders unfortunately can't detect any inventory slots other than the current held item, and the off-hand item. So there isn't anything I can do to implement this