ComplementaryDevelopment / ComplementaryReimagined

Complementary is a graphical rework pack for Minecraft with exceptional quality, detail, and performance.
https://www.complementary.dev/shaders/
Other
185 stars 53 forks source link

disable the torch Dynamic Handheld Lighting underwater #57

Closed peow closed 10 months ago

peow commented 10 months ago

i think it would be good to disable the torch's Dynamic Handheld Lighting underwater, and also Lava Bucket, because dont make any sense they work underwater (this is already a feature in LambDynamicLights)

2023-11-29_14 02 02

list of items that should not work underwater:

Torch Redstone Torch Lava Bucket Campfire Soul Campfire

Lantern, Glowstone and other blocks should still work

EminGT commented 10 months ago

I "shouldn't" add this feature, because I currently use an optimized way of doing dynamic lighting that avoids if-checks. We would need to switch the system to check for every single light source one by one every single frame at every single pixel in order to be able to add this.

peow commented 10 months ago

i see, okay