ComplianceAsCode / auditree-framework

The Auditree framework tool to run compliance control checks as unit tests.
https://auditree.github.io/
Apache License 2.0
59 stars 23 forks source link

Fixes from demonstrations in January 2023 #143

Closed ksnavely closed 1 year ago

ksnavely commented 1 year ago

What

In this pull request I seek to make the demo runnable again.

  1. The World Clock API is depreciated. Use a GitHub API which can be accessed easily and should be fairly stable.
  2. I suspect binary evidence support was broken when agent-mode was added. I tweaked a conditional to restore support for signed binary evidence.

Why

To better evangelize Auditree I want the demo working well.

How

Test

The demo is working, both the fetch step and the check step. Unit tests are passing.

Context

Try the demo off main today to see the failures. Linting and tests pass locally.

ksnavely commented 1 year ago

I'm accepting comments on this PR. I think a new test covering binary signed evidence would be a last change worth including -- it should fail off main today and pass on my branch.

drsm79 commented 1 year ago

Thanks for this, the change looks good from a quick eyeball. One thing, calling out to the API was a nice part of the demo, as it shows the whole collect remote responses. Obviously that needs to be a working API, maybe calling a GitHub api/URL for this project would be a good additional demo?

ksnavely commented 1 year ago

@drsm79 I've added a GitHub API example -- what do you think of using the versions API?

drsm79 commented 1 year ago

@drsm79 I've added a GitHub API example -- what do you think of using the versions API?

Nice, good choice.

ksnavely commented 1 year ago

I've added a binary signing test that now passes but fails on main.

cletomartin commented 1 year ago

@ksnavely perhaps we should merge #144 this first as it will fix some problems with the current CI config.

ksnavely commented 1 year ago

I should be good to go after you merge your PR @cletomartin , I can't recall if I'll need to re-push this branch after an update or not.

cletomartin commented 1 year ago

Yeah, there is some conflicts in there after my merge of #144