Closed ksnavely closed 1 year ago
I'm accepting comments on this PR. I think a new test covering binary signed evidence would be a last change worth including -- it should fail off main
today and pass on my branch.
Thanks for this, the change looks good from a quick eyeball. One thing, calling out to the API was a nice part of the demo, as it shows the whole collect remote responses. Obviously that needs to be a working API, maybe calling a GitHub api/URL for this project would be a good additional demo?
@drsm79 I've added a GitHub API example -- what do you think of using the versions API?
@drsm79 I've added a GitHub API example -- what do you think of using the versions API?
Nice, good choice.
I've added a binary signing test that now passes but fails on main.
@ksnavely perhaps we should merge #144 this first as it will fix some problems with the current CI config.
I should be good to go after you merge your PR @cletomartin , I can't recall if I'll need to re-push this branch after an update or not.
Yeah, there is some conflicts in there after my merge of #144
What
In this pull request I seek to make the demo runnable again.
Why
To better evangelize Auditree I want the demo working well.
How
Test
The demo is working, both the fetch step and the check step. Unit tests are passing.
Context
Try the demo off main today to see the failures. Linting and tests pass locally.