Re-run store_derived_evidence fetchers

[rhyshort]

• [x] Tick to sign-off your agreement to the Developer Certificate of Origin (DCO) 1.1

What

Ensure store_derived_evidence fetchers are re-run if dependent evidence is not yet available, this is achieved by get_evidence_dependency, rather than get_evidence_by_path.

Why

When running fetchers that store derived evidence, they often rely on evidence from previous fetchers, however if this evidence is not available the fetcher fails and is not automatically re-run because the store_derived_evidence function does not treat source evidence as dependency that can be re-run.

How

• Replace get_evidence_by_path call to get_evidence_dependency call in the decorator wrapper function.

Test

• Validated the current tests pass
• Validated the evidence is re-run

Context

[drsm79]

Good to hear from you Rhys. Is it possible to test the condition you describe? And show it fail before and succeed after the patch?

[rhyshort]

Yeah, I'll get the test case written

[rhyshort]

done

[cletomartin]

Thanks Rhys!

[rhyshort]

@cletomartin I don't have commit rights, could you merge please? 😄

[drsm79]

Merging, thanks @rhyshort